Fix: Do not expect response for initiatorType Ping requests#417
Merged
route merged 4 commits intorubycdp:mainfrom Jan 6, 2024
Merged
Fix: Do not expect response for initiatorType Ping requests#417route merged 4 commits intorubycdp:mainfrom
route merged 4 commits intorubycdp:mainfrom
Conversation
Member
|
Could you add a proper test with tag? |
Member
|
ping |
Contributor
Author
|
Updated - I have guessed a bit on where best to locate the new specs so if they need to be moved/re-arranged just let me know |
Member
|
Thanks! Merging, though I have some patch to apply on it after merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
HTML supports adding a
pingattribute to<a>tags. In such cases, the browser sents a POST request to the set URL(s) before navigating to the new URL (See w3schools doc here and Mozilla docs on initiatorType which includespingas an option).Unfortunately, because these requests do not receive a server response Ferrum adds them to the list of
pending_connections, meaning that subsequent calls towait_for_idlewill timeout waiting for these never-will-complete requests.Changes
Request#response_expected?method to indicate if the request expects a response from the server (currently 'ping' is the only request I know of that would not get a response)Exchange#response_expected?that calls the request method. Note, ifrequest.nil?we default totrueto match the current behaviourExchange#finished?so that any requests that do not expect responses are now also considered 'finished'